Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2246: Asynchronous media uploads #2246

Merged
merged 30 commits into from
Apr 25, 2023
Merged

MSC2246: Asynchronous media uploads #2246

merged 30 commits into from
Apr 25, 2023

Commits on Aug 24, 2019

  1. Proposal for asynchronous media uploads 

    Signed-off-by: Tulir Asokan <[email protected]>
    @tulir
    tulir committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    b439277 View commit details
    Browse the repository at this point in the history

  2. Add security consideration and mention possible /create request body 

    Signed-off-by: Tulir Asokan <[email protected]>
    @tulir
    tulir committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    a83c79c View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2019

  1. Expand on security consideration

    @tulir
    tulir committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    9a395ed View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2019

  1. Change error code for existing media PUT 

    Co-Authored-By: Travis Ralston <[email protected]>
    @tulir @turt2live
    tulir and turt2live authored Aug 26, 2019
    Configuration menu
    Copy the full SHA
    29e3463 View commit details
    Browse the repository at this point in the history

  2. Add spam prevention error, example response and auth requirements

    @tulir
    tulir committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    7cf22be View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2020

  1. Add query parameters to control downloading

    @tulir
    tulir committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    658aac8 View commit details
    Browse the repository at this point in the history

  2. Rename max_stall to max_stall_ms

    @tulir
    tulir committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    bbd7d08 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into asynchronous_uploads

    @tulir
    tulir committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    0bffcb7 View commit details
    Browse the repository at this point in the history

  4. Specify /create request body content

    @tulir
    tulir committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    4d009a9 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Update links, versions and prefixes

    @tulir
    tulir committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    1cbc04e View commit details
    Browse the repository at this point in the history

  2. Add recommended maximum delay for starting upload

    @tulir
    tulir committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    c65f2bf View commit details
    Browse the repository at this point in the history

  3. Explicitly deny uploading to other users' media IDs

    @tulir
    tulir committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    63cef50 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Prevent spam by ratelimiting instead of limiting number of IDs

    @tulir
    tulir committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    8ccf85f View commit details
    Browse the repository at this point in the history

  2. Remove streaming requirement 

    It's complicated
    @tulir
    tulir committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    12e907b View commit details
    Browse the repository at this point in the history

  3. Add unstable prefixes for new error codes

    @tulir
    tulir committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    d582bb3 View commit details
    Browse the repository at this point in the history

  4. Add missing words

    @tulir
    tulir committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    173edf3 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Change /create endpoint to use v1 

    Signed-off-by: Sumner Evans <[email protected]>
    @sumnerevans
    sumnerevans committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    f438754 View commit details
    Browse the repository at this point in the history

  2. Reorganize /upload spec and integrate feedback 

    * Explicitly specify that M_NOT_FOUND should be used for expired media
* Explicitly specify that M_FORBIDDEN should be used when a user other
  than the one who created the media ID tries to upload to it
* Remove content-length failure note

Signed-off-by: Sumner Evans <[email protected]>
    @sumnerevans
    sumnerevans committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    725675c View commit details
    Browse the repository at this point in the history

  3. Rename max_stall_ms -> timeout_ms 

    Signed-off-by: Sumner Evans <[email protected]>
    @sumnerevans
    sumnerevans committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    d55f1f9 View commit details
    Browse the repository at this point in the history

  4. Mention that maximum value for timeout_ms should be imposed by the se… 

    …rver

Signed-off-by: Sumner Evans <[email protected]>
    @sumnerevans
    sumnerevans committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    955177b View commit details
    Browse the repository at this point in the history

  5. Mention that the timeout_ms can be ignored if the media exists already 

    Signed-off-by: Sumner Evans <[email protected]>
    @sumnerevans
    sumnerevans committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    823fcca View commit details
    Browse the repository at this point in the history

  6. Change M_NOT_YET_UPLOADED to use 504 status code 

    Signed-off-by: Sumner Evans <[email protected]>
    @sumnerevans
    sumnerevans committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    3b00026 View commit details
    Browse the repository at this point in the history

  7. Remove retry_after_ms optional field 

    Signed-off-by: Sumner Evans <[email protected]>
    @sumnerevans
    sumnerevans committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    9627af2 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Make unused_expires_at the deadline for the upload to complete rather… 

    … than start

Signed-off-by: Sumner Evans <[email protected]>
    @sumnerevans
    sumnerevans committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    045c21e View commit details
    Browse the repository at this point in the history

  2. Add notes about suggested rate-limiting techniques 

    Namely, allowing a limited number of concurrent uploads

Signed-off-by: Sumner Evans <[email protected]>
    @sumnerevans
    sumnerevans committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    011031b View commit details
    Browse the repository at this point in the history

  3. Recommend 24 hours instead of 1 minute 

    Signed-off-by: Sumner Evans <[email protected]>
    @sumnerevans
    sumnerevans committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    6cb7e31 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Merge pull request #3 from beeper/async-uploads-rate-limiting-improve… 

    …ments

Async uploads rate limiting improvements
    @tulir
    tulir authored Mar 31, 2023
    Configuration menu
    Copy the full SHA
    fedc697 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Clarify that rate limiting can apply on /create and /upload 

    Signed-off-by: Sumner Evans <[email protected]>
    @sumnerevans
    sumnerevans committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    7652f59 View commit details
    Browse the repository at this point in the history

  2. Clarify that unused_expires_at is a POSIX millisecond timestamp 

    Signed-off-by: Sumner Evans <[email protected]>
    @sumnerevans
    sumnerevans committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    098dd90 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #4 from beeper/asynchronous_uploads 

    Updates from Travis' most recent review
    @tulir
    tulir authored Apr 20, 2023
    Configuration menu
    Copy the full SHA
    9559ab0 View commit details
    Browse the repository at this point in the history