Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC 1813 - Federation Make Membership Room Version #1813

Merged
merged 1 commit into from
Jan 29, 2019
Merged

MSC 1813 - Federation Make Membership Room Version #1813

merged 1 commit into from
Jan 29, 2019

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Jan 22, 2019 •
edited by turt2live
Loading

@erikjohnston erikjohnston changed the title MSC 1812 - Federation Make Membership Room Version MSC 1813 - Federation Make Membership Room Version Jan 22, 2019
@erikjohnston erikjohnston force-pushed the erikj/make_membership_room_ver branch from 8ac4c91 to 3ec3adb Compare January 22, 2019 10:55
@erikjohnston erikjohnston added proposal-in-review proposal A matrix spec change proposal labels Jan 22, 2019
@turt2live
Copy link
Member

turt2live commented Jan 22, 2019 •
edited
Loading

@erikjohnston this is already possible? https://matrix.org/docs/spec/server_server/unstable.html#get-matrix-federation-v1-make-join-roomid-userid

Edit: Oh I see, this is on the response. I should read all the words.

@richvdh richvdh self-requested a review January 24, 2019 10:34
@erikjohnston
Copy link
Member Author

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jan 24, 2019 •
edited by anoadragon453
Loading

Team member @erikjohnston has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Jan 24, 2019
@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jan 24, 2019
@mscbot
Copy link
Collaborator

mscbot commented Jan 24, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

turt2live added a commit that referenced this pull request Jan 29, 2019
@turt2live
Specify the room_version response property on /make_{leave|join}
70d82ea 
Original proposal: #1813
Implementation proof: matrix-org/synapse#4447

There are no changes from the original proposal.
@turt2live turt2live mentioned this pull request Jan 29, 2019
Merged
turt2live added a commit that referenced this pull request Jan 29, 2019
@turt2live
Specify the room_version response property on /make_{leave|join}
d12593f 
Original proposal: #1813
Implementation proof: matrix-org/synapse#4447

There are no changes from the original proposal.
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jan 29, 2019
@mscbot mscbot added finished-final-comment-period and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jan 29, 2019
@mscbot
Copy link
Collaborator

mscbot commented Jan 29, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@matrix-org matrix-org deleted a comment from mscbot Jan 29, 2019
@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed finished-final-comment-period labels Jan 29, 2019
@turt2live turt2live merged commit 2c3ba0b into master Jan 29, 2019
@turt2live
Copy link
Member

This was briefly in spec review while the FCP was going on, an as such has jumped from finished-final-comment-period to merged. No changes were proposed or concerns raised between the spec review and now, so the spec review stands.

Merged via #1821 🎉

@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

@richvdh richvdh richvdh approved these changes

Assignees

@erikjohnston erikjohnston

Labels
disposition-merge kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erikjohnston @turt2live @mscbot @richvdh @neilisfragile