Add support for unstable feature advertising via /versions #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've asked for the review of anyone on the core team, but would appreciate a review from @ara4n (to ensure accuracy with the proposal) and at least 1 other person. |
KitsuneRal
requested changes
Jan 8, 2019
|
@ara4n @KitsuneRal I'm not sure if I should take the silence as approving or busy - please let me know either way. Rich's approving review is appealing, but I also don't want people's opinions to be lost. |
KitsuneRal
reviewed
Jan 23, 2019
|
lgtm |
ara4n
approved these changes
Jan 23, 2019
KitsuneRal
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered: see 'docs' status check
Proposal: #1497
The only potential change (it is unclear in the proposal) is that the spec doesn't define the features that can be listed here. The rationale being that people can be courteous to each other and not pick identifiers which collide with other people's implementation where possible.