Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the room tagging documentation #1606

Merged
merged 3 commits into from
Aug 31, 2018
Merged

Update the room tagging documentation #1606

merged 3 commits into from
Aug 31, 2018

Conversation

turt2live
Copy link
Member

Rendered: see 'docs' status check

Includes changes provided by @KitsuneRal (thank you!)

Fixes #1565

  • Document the actual tag structure
  • Clarify the examples use floats (this is also now represented by the example tag using a float)
  • Fix other misc spec things (id -> ID, 'MUST NOT', indentation, etc)

KitsuneRal and others added 2 commits August 29, 2018 14:47
@KitsuneRal @turt2live
Elaborate the structure of m.tag events
9bc1470 
...and corresponding structures in tag-related CS API calls

Signed-off-by: Alexey Rusakov <[email protected]>
@turt2live
Minor touchups to the room tagging API
c03f2f8 
Fixes some of matrix-org#1565
@turt2live turt2live requested a review from a team August 29, 2018 20:56
richvdh
richvdh reviewed Aug 31, 2018
View reviewed changes
specification/modules/tags.rst
@@ -39,7 +39,7 @@ with an ``order`` of ``0.2`` would be displayed before a room with an ``order``
of ``0.7``. If a room has a tag without an ``order`` key then it should appear
after the rooms with that tag that have an ``order`` key.

The name of a tag MUST not exceed 255 bytes.
The name of a tag MUST NOT exceed 255 bytes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, this needs a better grammar :-S

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(raised as https://github.com/matrix-org/matrix-doc/issues/1639)

@turt2live turt2live merged commit afa16f1 into matrix-org:master Aug 31, 2018
@turt2live turt2live deleted the travis/c2s/room-tags branch August 31, 2018 14:36
@aaronraimist aaronraimist mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turt2live @richvdh @KitsuneRal