Proposal for adding full_state param to v2 sync #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -659,6 +659,8 @@ This API also returns an ``end`` token which can be used with the event stream. | |||
|
|
|||
| {{sync_http_api}} | |||
|
|
|||
| {{v2_sync_http_api}} | |||
There was a problem hiding this comment.
I guess it doesn't hurt to include this in the specification. We should add a preamble explaining how v2 /sync is supposed to work at some point. But I don't think it's essential that we do that now.
There was a problem hiding this comment.
It needs a lot more context. Really I just threw this in so that there's a way to check how it comes out in the spec doc.
|
LGTM |
richvdh
added a commit
to matrix-org/synapse
that referenced
this pull request
Oct 26, 2015
A hopefully-complete implementation of the full_state incremental sync, as specced at matrix-org/matrix-spec-proposals#133. This actually turns out to be a relatively simple modification to the initial sync implementation.
richvdh
added a commit
to matrix-org/sytest
that referenced
this pull request
Oct 26, 2015
Implement tests for the full_state incremental sync, as specced at matrix-org/matrix-spec-proposals#133 and implemented at matrix-org/synapse#332
|
This seems to work well in practice, so I'm going to ship it. |
richvdh
added a commit
that referenced
this pull request
Oct 28, 2015
Proposal for adding full_state param to v2 sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that, for clients like libpurple which store message history but not room state, it would be useful to provide an interface which provides the full state of a room, but only messages since the 'since' token.
This is a proposal for how it might look in the api.