Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec 'erase' param on /account/deactivate #1290

Closed
wants to merge 1 commit into from
Closed

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 11, 2018

@@ -348,6 +348,11 @@ paths:
description: |-
Additional authentication information for the user-interactive authentication API.
"$ref": "definitions/auth_data.yaml"
erase:
description: |-
Indicates whether the account should be erased. Defaults to `false`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the server expected to erase?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the doc comment from js sdk :(

@maxidorius
Copy link
Contributor

Spec proposal?

@t3chguy
Copy link
Member Author

t3chguy commented Jun 13, 2018

the issue is marked as spec-omission so clearly its already accepted into the spec, just not documented.

@non-Jedi
Copy link
Contributor

I disagree that this is a spec omission. All of the stuff added for GDPR needs to go through the formal proposal process before it's added to the spec. It's not like this is stuff that's been implemented in riot-web/synapse for forever and we're just documenting it now. This is behavior that's been added either after the proposal process was implemented or close to concurrent with it.

@t3chguy
Copy link
Member Author

t3chguy commented Jun 14, 2018

Then the triaging needs to change.

@turt2live
Copy link
Member

There's been quite a few mentions that spec-omission doesn't always mean it can go straight to PR. I believe this is one of those cases where an overarching GDPR proposal is needed.

I'll add this to the bucket of GDPR things though

@richvdh
Copy link
Member

richvdh commented Jul 24, 2018

ok let's close this for now pending a GDPR spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants