Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec lazy_load_members and include_redundant_members #1287

Closed
wants to merge 1 commit into from
Closed

spec lazy_load_members and include_redundant_members #1287

wants to merge 1 commit into from

Conversation

ara4n
Copy link
Member

@ara4n ara4n commented Jun 10, 2018

as per #1227

@benparsons benparsons mentioned this pull request Jun 10, 2018
Closed
@turt2live turt2live added proposal-wip proposal A matrix spec change proposal labels Jul 30, 2018
@ara4n
Copy link
Member Author

ara4n commented Aug 15, 2018

this needs to handle the question of how we negotiate the presence of LL (it might just be checking for version > 0.4.0) before being merged. See also #1497

@turt2live turt2live added the client-server Client-Server API label Sep 5, 2018
@KitsuneRal KitsuneRal mentioned this pull request Nov 11, 2018
Closed
@KitsuneRal
Copy link
Member

As I got to implementing this in libQMatrixClient - these two parameters only make sense (and effect) if supplied in the state section of the filter. Maybe move them to sync_filter.yaml then? I'll draft the proposed change and post the link here.

@KitsuneRal
Copy link
Member

KitsuneRal commented Nov 24, 2018 •
edited
Loading

This should be better: quotient-im@fb612be (feel free to cherry-pick).

@KitsuneRal
Copy link
Member

KitsuneRal commented Dec 11, 2018 •
edited
Loading

Independent implementation interoperable with the current Synapse at matrix.org: quotient-im/libQuotient#263 (uses #688 and #1337 along with this PR).

@KitsuneRal
Copy link
Member

KitsuneRal commented Dec 15, 2018 •
edited
Loading

By the way, what is the (older) Synapse reaction if I supply lazy_load_members in a filter but the homeserver doesn't support it?

@KitsuneRal KitsuneRal mentioned this pull request Dec 15, 2018
Merged
@turt2live turt2live removed the proposal A matrix spec change proposal label Dec 17, 2018
@richvdh richvdh mentioned this pull request Dec 18, 2018
Merged
@richvdh
Copy link
Member

richvdh commented Dec 18, 2018

By the way, what is the (older) Synapse reaction if I supply lazy_load_members in a filter but the homeserver doesn't support it?

synapse ignores unrecognised fields in filters

@bwindels
Copy link
Contributor

bwindels commented Feb 5, 2019

Not sure this is mentioned in any of the related Google docs or elsewhere, but I remember we decided towards the end of implementing LL that the server should always send the membership event during initial sync for the syncing user.

@KitsuneRal
Copy link
Member

Should this be closed now that #1758 is in?

@turt2live
Copy link
Member

This looks redundant - closing.

@turt2live turt2live closed this May 27, 2019
@turt2live turt2live mentioned this pull request Mar 1, 2022
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees

@ara4n ara4n

Labels
client-server Client-Server API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ara4n @KitsuneRal @richvdh @bwindels @turt2live