Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET media/config #1189

Merged
merged 18 commits into from
Jul 6, 2018
Merged

GET media/config #1189

Changes from 3 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2783820
Initial draft of GET media/limits
Half-Shot May 3, 2018
c9abf36
size > upload_size
Half-Shot May 3, 2018
de6fe1b
Add note about auth
Half-Shot May 3, 2018
ffc8ee2
a upload > an upload
Half-Shot May 8, 2018
077cd04
/limits => /config
Half-Shot Jun 20, 2018
6b9640b
upload_size => m.upload.size
Half-Shot Jun 20, 2018
6d0a56d
Suggestions by Travis tend to be sensible ones
Half-Shot Jun 22, 2018
ddc1523
Extending words and rate limiting
Half-Shot Jun 27, 2018
80935ea
Update content-repo.yaml
Half-Shot Jun 27, 2018
eeaf438
Speling is my weakniss
Half-Shot Jun 28, 2018
091b2a6
Hard limit on requiring accessToken. Rephrased some sections
Half-Shot Jun 28, 2018
1820df0
media => content repository
Half-Shot Jun 28, 2018
21e957e
Better note for /config
Half-Shot Jun 28, 2018
41c18be
+repository
Half-Shot Jun 28, 2018
a1309d6
Remove "Clients should handle gracefully" sentence
Half-Shot Jun 29, 2018
d5ce87e
Split summary up into description and summary
Half-Shot Jul 6, 2018
2e6cc80
Better indent of description
Half-Shot Jul 6, 2018
77f4ac5
Wordy intro sentence for description
Half-Shot Jul 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions api/client-server/content-repo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,3 +269,33 @@ paths:
"$ref": "definitions/error.yaml"
tags:
- Media
"/limits":
get:
summary: Get limits on what can be uploaded to the content repository.
Clients SHOULD use this as a guide when uploading content.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to clarify what it's talking about now, since this is now a generic /config API.

Edit: in fact this probably just needs to move to m.upload.size below

All values are intentionally left optional, the client MUST assume
that any field not given is not limited.

**NOTE:** Reverse proxies may apply their own limits.

If auth is not supplied, this endpoint gives the global limit of the server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gives the s/limit/configuration of the server

likewise below: Otherwise it should give the s/limits/configuration for the authenticated user.

and again: full words would be nice (authorization vs auth)

Otherwise it should give the limits applied to the authenticated user.
operationId: getLimits
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be updated

produces: ["application/json"]
security:
- accessToken: []
responses:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a 429 should be added to indicate rate limiting:

         429:
           description: This request was rate-limited.
           schema:
             "$ref": "definitions/error.yaml"

200:
description: The limits exposed by the matrix server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this endpoint is generic now, the general description should probably be generic as well.

How does "The public content repository configuration for the matrix server." sound to you?

schema:
type: object
properties:
upload_size:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proposal calls for m.upload.size btw (same with the example later on)

type: number
description: "The maximum size a upload can be in bytes."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an upload

examples:
application/json: {
"upload_size": 50000000
}
tags:
- Media