Spec /account/whoami #1063
Merged
Spec /account/whoami #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Travis Ralston <[email protected]>
|
Can one of the admins verify this patch? |
Signed-off-by: Travis Ralston <[email protected]>
Signed-off-by: Travis Ralston <[email protected]>
|
matrixbot: test this please |
richvdh
requested changes
Nov 13, 2017
| application/json: { | ||
| "user_id": "@joe:example.org" | ||
| } | ||
| schema: |
There was a problem hiding this comment.
this needs a required: ['user_id'] (iirc)
There was a problem hiding this comment.
I'm not seeing that on other response schemas, is that needed for both responses and requests?
I've addressed the other concerns.
There was a problem hiding this comment.
I've added the required node. All of the references I used didn't have it, but some older documentation does (media repo, for instance).
api/client-server/whoami.yaml
Outdated
| # limitations under the License. | ||
| swagger: '2.0' | ||
| info: | ||
| title: "Matrix Client-Server Client Config API" |
There was a problem hiding this comment.
this looks like an inappropriate c&p.
api/client-server/whoami.yaml
Outdated
| summary: Gets information about the owner of an access token. | ||
| description: |- | ||
| Gets information about the owner of a given access token. Currently this | ||
| only supports returning the user id that owns the token. |
There was a problem hiding this comment.
I'm not sure this second sentence is adding any value tbh.
Signed-off-by: Travis Ralston <[email protected]>
Signed-off-by: Travis Ralston <[email protected]>
richvdh
approved these changes
Nov 14, 2017
|
THanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients may wish to be able to identify which user they are supposed to be representing from only an access token. This new endpoint gives limited information to the client about the authenticated user.