-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event ID's should be hashes and the hashes field should not exist. #1127
Comments
the So we have two hashes, the "content hash", which is based on the complete unredacted event; and the "reference hash", which is based on the redacted event in the same way as the signature. The So, everything you said is true, except that the |
So the Correction: Specifically |
Fixed by #1659 :) |
* keys.yml: fix one_time_keys object contents The alternatives previously listed under two additionalProperties levels are actually one _more_ level deeper; we still can't define them in a formal way before moving to OpenAPI 3 but at least let's be honest and say there's always a dict where there's always a dict. Also, since the same data structure is used in three places now, at least give it a name, and document the actual definition (once) separately (not using it now because it's OpenAPI 3). * Changelog
Appendix 4.2.2 "Room IDs and Event IDs" states:
There is no benefit to event ID's being opaque. A vehicle for useful federated information is lost by not standardizing the format of event ID's further than the sigil prefix and domain postfix. The effect of this loss is seen by:
Having to include additional structure in each event for a
hashes
object specified in Federation unstable.4.1 "PDU Fields."Having to include additional structure in every single
prev_event
,prev_state
, andauth_events
list for a hashes object.As one of several possible suggestions to improve this, the future specifier should consider the following:
The text was updated successfully, but these errors were encountered: