Skip to content

Commit

Permalink
Disallow invite->knock membership changes
Browse files Browse the repository at this point in the history
  • Loading branch information
anoadragon453 committed Nov 27, 2020
1 parent 6c75b83 commit 7dcff8f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions proposals/2403-knock.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ rules from room version 5 are:
a. If `membership` is `knock`:
i. If the `join_rule` is anything other than `knock`, reject.
ii. If `sender` does not match `state_key`, reject.
iii. If the `sender`'s membership is not `ban`, `knock` or `join`, allow.
iii. If the `sender`'s membership is not `ban`, `knock`, `invite` or `join`, allow.
iv. Otherwise, reject.
```

Expand All @@ -67,7 +67,8 @@ rules from room version 5 are:
- a.ii is justified as one user should not be able to knock on behalf of
another user.
- a.iii is justified as knocks should not be allowed if the knocking user
has been banned from the room, or if they are already in the room.
has been banned from the room, has already knocked on the room, is
invited to the room or if they are already in the room.
- Knocks are not restricted by power level like invites are. The `join_rules`
are already used to enforce whether someone can or cannot knock.

Expand Down

0 comments on commit 7dcff8f

Please sign in to comment.