-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appservice): Add default request config #998
Conversation
a3adc8e
to
c1a176f
Compare
Codecov ReportBase: 78.46% // Head: 78.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
==========================================
- Coverage 78.46% 78.41% -0.05%
==========================================
Files 110 110
Lines 15121 15133 +12
==========================================
+ Hits 11864 11867 +3
- Misses 3257 3266 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
c1a176f
to
b82c7fe
Compare
b66fe88
to
f1f918f
Compare
f1f918f
to
53e052b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Would be good if the change to a builder pattern was a separate commit or even PR. Also there should be AppService::builder
like there is Client::builder
, so one doesn't have to import the builder type for common usage.
Opened a new PR for the builder pattern with the requested changes in #1051. |
With #1051 merged, this is now waiting on a rebase. |
b76381a
to
973c3e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, just one nitpick.
c17cb3d
to
39444db
Compare
This isn't actually a breaking change now that the conversion to builder pattern has already happened, right? |
This adds a default RequestConfig to use when creating new virtual clients.
39444db
to
7417d86
Compare
Adds an optional default RequestConfig to the appservice struct, which when present is used for any virtual clients created.
Closes #925