Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI coverage reporting #700

Merged
merged 3 commits into from
May 20, 2022

Conversation

gnunicorn
Copy link
Contributor

  • split coverage in multiple sections: default for crates, bindings and labs as informational (not mandataory)
  • disable patch-level analytics - we don't care that n% of lines in that PR were hit, only project wide statistics

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something needs to be done for the matrix-sdk-crypto-ffi crate as well, either move it into the bindings directory or add special handling.

The matrix-sdk-indexeddb crate should also be added to the tarpaulin.toml exclude section.

codecov.yaml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #700 (dd1f817) into main (d6c6211) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #700   +/-   ##
=======================================
  Coverage   72.63%   72.63%           
=======================================
  Files         107      107           
  Lines       15932    15932           
=======================================
  Hits        11572    11572           
  Misses       4360     4360           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6c6211...dd1f817. Read the comment docs.

@gnunicorn
Copy link
Contributor Author

unfortunately, I can not add ignores in the path, so we have to spell out each folder... need to remember that if we added more crates to crates/ ...

I've also outcommented "wasm" with reference to the pending issue...

@gnunicorn gnunicorn merged commit 017359b into matrix-org:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants