feat: Remove the experimental-sliding-sync feature flag
#4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
requested review from
jmartinesp and
poljar
and removed request for
a team and
jmartinesp
Hywan
force-pushed
the
feat-remove-feature-flag-experimental-sliding-sync
branch
from
86e59b1 to
818b8a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4483 +/- ##
==========================================
+ Coverage 85.31% 85.36% +0.05%
==========================================
Files 284 284
Lines 31741 31885 +144
==========================================
+ Hits 27080 27219 +139
- Misses 4661 4666 +5 ☔ View full report in Codecov by Sentry. |
Hywan
force-pushed
the
feat-remove-feature-flag-experimental-sliding-sync
branch
from
6becf8d to
8853be3
Compare
Hywan
force-pushed
the
feat-remove-feature-flag-experimental-sliding-sync
branch
4 times, most recently
from
ca9daef to
81b1294
Compare
|
@poljar The PR is finally ready for a review. CI has caught an issue with |
Sliding sync is no longer experimental. It has a solid MSC4186, along with a solid implementation inside Synapse. It's time to consider it mature. The SDK continues to support the old MSC3575 in addition to MSC4186. This patch only removes the `experimental-sliding-sync` feature flag.
…with `wasm32-u-u`.
This patch removes `SlidingSyncRoomInner::client` because, first off, it's not `Send`, and second, it's useless. Nobody uses it, it's basically dead code… annoying dead code… bad dead code!
Hywan
force-pushed
the
feat-remove-feature-flag-experimental-sliding-sync
branch
from
05948a9 to
93d18e6
Compare
|
(rebased on top of |
jplatte
approved these changes
Jan 8, 2025
|
Yes I agree. I've already extracted multiple patches into their own PR, I should have continue this process. Thanks for the approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sliding sync is no longer experimental. It has a solid MSC4186, along with a solid implementation inside Synapse. It's time to consider it mature.
The SDK continues to support the old MSC3575 in addition to MSC4186. This patch only removes the
experimental-sliding-syncfeature flag.