task(crypto): Support receiving stable identifier for MSC4147

[andybalaam]

Part of element-hq/element-meta#2665

On the receiving side, allow sender_device_keys as well as org.matrix.msc4147.device_keys for the sender's device keys in to-device event. Once this has time to bed in, we will change the sending side to use this stable identifier since the MSC has been merged.

• Public API changes documented in changelogs (optional)

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.42%. Comparing base (bc8c4f5) to head (e557586).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...rates/matrix-sdk-crypto/src/types/events/olm_v1.rs	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4420   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         283      283           
  Lines       31556    31556           
=======================================
  Hits        26958    26958           
  Misses       4598     4598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BillCarsonFr]

I tought that the trick was to use serde(alias = ?
how is it working here?

[bnjbvr]

Yep, unless I'm missing something, this is only renaming the variable when it's used on the Rust side, so this is an internal renaming, so this may not be what you intended to do?

[poljar]

Err, it's renaming the field during serialization/deserialization. The serialized JSON will contain org.matrix.msc4147.device_keys during serialization and we will expect org.matrix.msc4147.device_keys during deserialization. While the code have the more pleasant name.

[andybalaam]

Well spotted! A fix, and, critically, a test that proves it works, are in c093e7c

[bnjbvr]

Yep, unless I'm missing something, this is only renaming the variable when it's used on the Rust side, so this is an internal renaming, so this may not be what you intended to do?

[bnjbvr]

We do use mostly "deserialize" in this simplified en-us code base, but that might not be review comment worthy. LGTM :)

[andybalaam]

We do use mostly "deserialize" in this simplified en-us code base, but that might not be review comment worthy. LGTM :)

Thanks, fixed in 17f074b

[BillCarsonFr]

Thx, LGTM.