Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove image-proc feature and functions to generate a thumbnail #4132

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Oct 16, 2024

Since no one seems to use it, according to our discussion in the Dev room.

The second commit, on top of the first, allows to remove a bunch of dependencies in Cargo.lock.

Gets rid of dependencies for the different image formats.

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh requested a review from a team as a code owner October 16, 2024 08:36
@zecakeh zecakeh requested review from jmartinesp and removed request for a team October 16, 2024 08:36
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (ee4ef2e) to head (8504ff7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4132      +/-   ##
==========================================
- Coverage   84.72%   84.70%   -0.02%     
==========================================
  Files         269      269              
  Lines       28837    28770      -67     
==========================================
- Hits        24432    24371      -61     
+ Misses       4405     4399       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmartinesp jmartinesp merged commit 3d04234 into matrix-org:main Oct 16, 2024
41 checks passed
@zecakeh zecakeh deleted the remove-image-proc branch October 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants