rtc: Handle non-MXID call member event state keys

[AndrewFerr]

Update Ruma dependency to expect call membership state events with state keys that are arbitrary strings, not just pure MXIDs.

When a call membership state key does not exactly match the format of an MXID, treat it as a valid state key if it starts with an MXID followed by an underscore, with that MXID designating the owner of the event.

(The state key may also be optionally prefixed with an underscore, which is permitted as a way to bypass pre-MSC3757 authorization rules against sending state events with state keys that do not exactly match the sender's MXID.)

• Public API changes documented in changelogs (optional)

Signed-off-by: Andrew Ferrazzutti [email protected]

[codecov]

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.13%. Comparing base (35b62a1) to head (ca47e8a).
Report is 17 commits behind head on main.

Files	Patch %	Lines
crates/matrix-sdk-base/src/rooms/mod.rs	93.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3836      +/-   ##
==========================================
+ Coverage   84.12%   84.13%   +0.01%     
==========================================
  Files         263      263              
  Lines       27592    27605      +13     
==========================================
+ Hits        23211    23225      +14     
+ Misses       4381     4380       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bnjbvr]

Thanks, looks sane but it'd be nice to have some basic unit tests (which would also show what behavior is expected and what isn't).

[bnjbvr]

(Sorry @stefanceriu, I hadn't seen you removed my review request, and the PR is simple enough that I could take a look — feel free to re-take over if you prefer!)

[stefanceriu]

I hadn't seen you removed my review request

Oh no worries, I only removed you because I can test it end to end, but it doesn't really matter.

It seems to work just fine on both call.element.io and call.element.dev so from my point of view you can merge it after adressing benji's concerns. Nicely done! 👍

[bnjbvr]

Getting closer, thanks for making a separate function and writing tests!

[bnjbvr]

Looks good to me, modulo test nits, thanks! Please push another commit with the test changes, and then no need to ask for another review, I'll merge it 👍

[bnjbvr]

I've addressed the nits for you actually, so we can merge :)