Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: split up the machine.rs behemoth #3813

Merged
merged 10 commits into from
Aug 8, 2024
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Aug 7, 2024

The machine.rs file has become increasingly unwieldy, and hard to navigate. In particular, it's hard to figure out what we have in the way of tests, because there are just 3000 lines of rather opaque tests.

By way of trying to improve the situation, I've split the tests out to a separate file, and thence tried to extract some themes. It's slightly arbitrary, but maybe better than nothing.

I'm not sure if this is going to be reviewable in the conventional manner :/.

@richvdh richvdh requested a review from a team as a code owner August 7, 2024 16:29
@richvdh richvdh requested review from jmartinesp and removed request for a team August 7, 2024 16:29
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 85.63135% with 99 lines in your changes missing coverage. Please review.

Project coverage is 84.12%. Comparing base (f3fe06b) to head (045374c).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/matrix-sdk-crypto/src/machine/mod.rs 85.63% 99 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3813      +/-   ##
==========================================
- Coverage   84.15%   84.12%   -0.03%     
==========================================
  Files         263      263              
  Lines       27584    27584              
==========================================
- Hits        23213    23206       -7     
- Misses       4371     4378       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richvdh richvdh force-pushed the rav/split_machine_tests branch from a1556d0 to 045374c Compare August 8, 2024 10:44
@richvdh richvdh merged commit 9c809b9 into main Aug 8, 2024
40 checks passed
@richvdh richvdh deleted the rav/split_machine_tests branch August 8, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants