crypto: Allow querying InboundGroupSessions using curve key #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
changed the base branch from
main
to
andybalaam/schema-for-finding-igs-for-device
andybalaam
changed the title
richvdh
force-pushed
the
andybalaam/schema-for-finding-igs-for-device
branch
from
9c80560 to
b08403f
Compare
Base automatically changed from
andybalaam/schema-for-finding-igs-for-device
to
andyrich/sender-data-from-keys-query
August 7, 2024 13:20
richvdh
force-pushed
the
andyrich/sender-data-from-keys-query
branch
from
b08403f to
bc3fdcf
Compare
richvdh
force-pushed
the
andybalaam/query-for-igs-by-curve-key
branch
from
adb6b19 to
928157f
Compare
richvdh
force-pushed
the
andyrich/sender-data-from-keys-query
branch
from
bc3fdcf to
5d7bf58
Compare
richvdh
force-pushed
the
andyrich/sender-data-from-keys-query
branch
from
5d7bf58 to
833ff32
Compare
richvdh
force-pushed
the
andybalaam/query-for-igs-by-curve-key
branch
from
928157f to
2d9fe4d
Compare
richvdh
force-pushed
the
andyrich/sender-data-from-keys-query
branch
from
833ff32 to
68dd910
Compare
This comment was marked as resolved.
This comment was marked as resolved.
richvdh
force-pushed
the
andyrich/sender-data-from-keys-query
branch
5 times, most recently
from
b40fefe to
d785bb8
Compare
richvdh
force-pushed
the
andybalaam/query-for-igs-by-curve-key
branch
from
2d9fe4d to
d785bb8
Compare
richvdh
changed the base branch from
andyrich/sender-data-from-keys-query
to
main
richvdh
force-pushed
the
andybalaam/query-for-igs-by-curve-key
branch
from
3d9d3fc to
d785bb8
Compare
richvdh
force-pushed
the
andybalaam/query-for-igs-by-curve-key
branch
from
d785bb8 to
99f672e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3806 +/- ##
==========================================
- Coverage 84.16% 84.12% -0.05%
==========================================
Files 266 266
Lines 28017 28088 +71
==========================================
+ Hits 23581 23629 +48
- Misses 4436 4459 +23 ☔ View full report in Codecov by Sentry. |
|
Seems like the coverage data is wrong here. It seems like it's treating the text of the SQL statement at https://app.codecov.io/gh/matrix-org/matrix-rust-sdk/pull/3806/blob/crates/matrix-sdk-sqlite/src/crypto_store.rs#L517 as a coverage miss... but clearly that method is being executed, so the SQL statement must be being used. I wonder if it would help to pull the text out to a separate |
richvdh
requested review from
Hywan and
richvdh
and removed request for
a team
richvdh
force-pushed
the
andybalaam/query-for-igs-by-curve-key
branch
2 times, most recently
from
3ff54b7 to
5177e3f
Compare
Add new `session_id`, `sender_key` and `sender_data_type` properties to stored inbound group session objects.
Add an index on `(sender_key, sender_data_type, session_id)`.
Add a new integration test for `CryptoStore::get_inbound_group_sessions_for_device_batch`
richvdh
force-pushed
the
andybalaam/query-for-igs-by-curve-key
branch
from
0f0df00 to
aa3757f
Compare
richvdh
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
@andybalaam I co-wrote this and have co-reviewed it. We're both now happy with the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method
CryptoStore::get_inbound_group_sessions_for_device_batch, which is required for us to be able to update the information we hold about inbound group sessions when we get a/keys/queryresponse (#3753).Strongly suggest reviewing commit-by-commit!
Fixes #3752