sdk-ui: add PinnedEventsLoaderError::TimelineReloadFailed
#3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error will be returned when the room has pinned event ids but the timeline couldn't load any of them. Also fix tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error will be returned when the room has pinned event ids but the timeline couldn't load any of them.
We need to make this distinction instead of just failing as soon as the first request fails because we don't want an incorrect pinned event id to break loading any other existing events, or have a single failed request with poor connectivity to invalidate the rest of them.
Also fix and add new tests.
Signed-off-by: