ffi: add RoomPinnedEventsChange enum and a diffing step
#3801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
force-pushed
the
jme/feat/message-pinning-contents-diff
branch
2 times, most recently
from
823e3e0 to
bbcf922
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3801 +/- ##
==========================================
+ Coverage 84.08% 84.09% +0.01%
==========================================
Files 262 263 +1
Lines 27456 27476 +20
==========================================
+ Hits 23087 23107 +20
Misses 4369 4369 ☔ View full report in Codecov by Sentry. |
andybalaam
approved these changes
Aug 5, 2024
| @@ -381,7 +394,49 @@ impl From<&matrix_sdk_ui::timeline::AnyOtherFullStateEventContent> for OtherStat | |||
| }; | |||
| Self::RoomName { name } | |||
| } | |||
| Content::RoomPinnedEvents(_) => Self::RoomPinnedEvents, | |||
| Content::RoomPinnedEvents(c) => { | |||
There was a problem hiding this comment.
This is a massive chunk, which I'd prefer to have in a separate function, and unit tested, if possible.
There was a problem hiding this comment.
Yeah, that's probably a good idea. Thanks!
…pened in the last pinning/unpinning events action
jmartinesp
force-pushed
the
jme/feat/message-pinning-contents-diff
branch
from
a9bdcd5 to
665c2c2
Compare
andybalaam
approved these changes
Aug 6, 2024
| @@ -0,0 +1,178 @@ | |||
| use std::collections::HashSet; | |||
There was a problem hiding this comment.
Oh, weird. I expected the IDE to automatically add it 🤔 .
jmartinesp
force-pushed
the
jme/feat/message-pinning-contents-diff
branch
from
665c2c2 to
cf28c8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to give the clients some context of what happened in the last pinning/unpinning events action so they can display the right info in the timeline events.
Signed-off-by: