-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Session cache from the cryptostore implementations #3799
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3799 +/- ##
==========================================
- Coverage 84.11% 84.07% -0.05%
==========================================
Files 263 263
Lines 27476 27475 -1
==========================================
- Hits 23111 23099 -12
- Misses 4365 4376 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having no clue about the underlying crypto logic the code makes sense to me. LGTM but maybe we want someone else's review here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
d4483e9
to
7a78443
Compare
This PR is another step in the #2624 epic. It moves the Olm
Session
cache from each individual cryptostore implementation to theCryptoStoreWrapper
.While the wrapper shouldn't be the final destination for this cache it does help with our current multi-process support which relied on the
CryptoStore::clear_caches()
method. This method is now gone and no further caches should be added to the store implementations.Review commit by commit isn't advised as the API changed and changed back when the cache was removed and re-added.