Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NDK 27 for the Kotlin bindings #3798

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

jmartinesp
Copy link
Contributor

@jmartinesp jmartinesp commented Aug 2, 2024

This seems to fix the Kotlin bindings issues we were seeing until now.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@jmartinesp jmartinesp requested a review from a team as a code owner August 2, 2024 14:39
@jmartinesp jmartinesp requested review from poljar and removed request for a team August 2, 2024 14:39
@jmartinesp jmartinesp force-pushed the jme/fix/ci-kotlin-bindings-ndk-27 branch from 62d9de3 to fe6994a Compare August 2, 2024 14:40
@jmartinesp jmartinesp changed the title sdk: move PinnedEventCache from sdk-ui Use NDK 27 for the Kotlin bindings Aug 2, 2024
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@be6bc44). Learn more about missing BASE report.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3798   +/-   ##
=======================================
  Coverage        ?   84.06%           
=======================================
  Files           ?      261           
  Lines           ?    27365           
  Branches        ?        0           
=======================================
  Hits            ?    23005           
  Misses          ?     4360           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp force-pushed the jme/fix/ci-kotlin-bindings-ndk-27 branch from fe6994a to b8c9d7a Compare August 2, 2024 15:12
@jmartinesp
Copy link
Contributor Author

Sorry, I had to revert fe6994a because the resulting APK failed with the known cannot locate symbol: "__extenddftf2" error the workaround fixes.

@jmartinesp jmartinesp enabled auto-merge (rebase) August 2, 2024 15:25
@jmartinesp jmartinesp merged commit 769a627 into main Aug 2, 2024
40 checks passed
@jmartinesp jmartinesp deleted the jme/fix/ci-kotlin-bindings-ndk-27 branch August 2, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants