-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crypto | Add support for verified identities change detection. #3795
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b4fe305
crypto: Remember and detect verified identity changes for #1129
BillCarsonFr 3d3f93a
crypto: Verified identity changes TDD
BillCarsonFr 0e01b1d
crypto: Verified identity changes - Update latch on identity update
BillCarsonFr 20f717e
crypto: Verified Identity changes - Update latch on own trust change
BillCarsonFr c171c51
crypto: Verified identity changes Fix test with memory store
BillCarsonFr 3c9ae33
crypto: Verified identity changes - Migration of existing data
BillCarsonFr 58c4075
Review: CI fix identity serialization test
BillCarsonFr d81b12f
Review: Fix false postitive typo in b64 string
BillCarsonFr 2e410e5
CodeReview: rename verification_latch to previously verified
BillCarsonFr 7e9f4fc
CodeReview: Clarify comment
BillCarsonFr 072b5d5
Fix typo in method name
BillCarsonFr 1b05380
Crypto: Verified identity changes - Add API at UserIdentity level + test
BillCarsonFr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
crypto: Verified identity changes TDD
- Loading branch information
commit 3d3f93a33dbb169282be0db76fc83d7ff95c1425
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit: "crypto: Verified identity changes TDD" - I would say that the tests for something could be in the same commit as the code itself, so no need for a separate commit here.
If you want a separate commit I suggest "crypto: Tests for verified_latch" or similar.