Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Make the return type of is_owner_of_session more specific #3774

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

andybalaam
Copy link
Member

Make the return type of is_owner_of_session more specific, so we can use it in contexts that expect e.g. an OlmError instead of MegolmError.

Part of #3751

@andybalaam andybalaam requested a review from a team as a code owner July 29, 2024 12:29
@andybalaam andybalaam requested review from stefanceriu and removed request for a team July 29, 2024 12:29
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.08%. Comparing base (d7224a7) to head (81cc3b9).

Files Patch % Lines
crates/matrix-sdk-crypto/src/error.rs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3774      +/-   ##
==========================================
- Coverage   84.09%   84.08%   -0.01%     
==========================================
  Files         259      259              
  Lines       27089    27094       +5     
==========================================
+ Hits        22780    22782       +2     
- Misses       4309     4312       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andybalaam andybalaam merged commit 0b46a7e into main Jul 29, 2024
40 checks passed
@andybalaam andybalaam deleted the andybalaam/more-specific-errors-for-is-owner branch July 29, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants