crypto: Change DB schemata to add next_retry_time_ms property/column for InboundGroupSessions #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
force-pushed
the
andybalaam/db-schema-for-retry-time
branch
from
d701778 to
35fe554
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3733 +/- ##
==========================================
- Coverage 84.01% 83.98% -0.03%
==========================================
Files 260 260
Lines 26719 26764 +45
==========================================
+ Hits 22447 22479 +32
- Misses 4272 4285 +13 ☔ View full report in Codecov by Sentry. |
poljar
reviewed
Jul 19, 2024
andybalaam
force-pushed
the
andybalaam/db-schema-for-retry-time
branch
from
35fe554 to
e91f0f8
Compare
|
Converted to draft because we think we can design this without a retry mechanism at all. |
|
No longer needed - see the updated plan in #3544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3545
Review commit by commit.
This allows us to find
InboundGroupSessions based on theirnext_retry_time_ms, setting us up to be able to retry findingSenderDatafor sessions even if we failed to do it first time.