Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(base): New RoomInfoNotableUpdateReasons::READ_RECEIPT #3680

Merged
merged 5 commits into from
Jul 10, 2024
+115 −18
Merged

feat(base): New RoomInfoNotableUpdateReasons::READ_RECEIPT #3680

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
657b046
doc(base): Remove an outdated documentation information.
Hywan Jul 10, 2024
efd9a75
test(base): Test `RoomInfoNotableUpdateReason::RECENCY_TIMESTAMP` is …
Hywan Jul 10, 2024
168f285
feat(base): New `RoomInfoNotableUpdateReasons::READ_RECEIPT`!
Hywan Jul 10, 2024
b046794
feat(ui): `RoomList` is refreshed by `RoomInfoNotableUpdateReasons::R…
Hywan Jul 10, 2024
a4e47fd
chore(base): Format doc.
Hywan Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/matrix-sdk-base/src/sliding_sync.rs
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fold 0e73620 into the commits it belongs to (consider git-absorb next time!)

Original file line number Diff line number Diff line change
Expand Up @@ -1866,7 +1866,8 @@ mod tests {
let response = response_with_room(room_id, room);
client.process_sliding_sync(&response, &()).await.expect("Failed to process sync");

// Then a room info notable update is NOT received, because it's the first time the room is seen.
// Then a room info notable update is NOT received, because it's the first time
// the room is seen.
assert_matches!(
room_info_notable_update_stream.recv().await,
Ok(RoomInfoNotableUpdate { room_id: received_room_id, reasons: received_reasons }) => {
Expand Down Expand Up @@ -1913,7 +1914,8 @@ mod tests {
}
);

// When I send sliding sync response containing a couple of events with no read receipt.
// When I send sliding sync response containing a couple of events with no read
// receipt.
let room_id = room_id!("!r:e.uk");
let events = vec![
make_raw_event("m.room.message", "$3"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make_raw_event and make_event should be replaced with the EventFactory 😇

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire test suite should be revisited. Later. For another time. But I agree!

Expand Down
Loading