crypto: Pass room id and session id to room_keys_withheld_received_stream
#3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/withheld_key_stream_again
branch
from
e7f0a2b to
a0fdadb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3674 +/- ##
=======================================
Coverage 84.34% 84.35%
=======================================
Files 259 259
Lines 26723 26727 +4
=======================================
+ Hits 22540 22546 +6
+ Misses 4183 4181 -2 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Jul 10, 2024
| @@ -913,6 +913,20 @@ impl From<&InboundGroupSession> for RoomKeyInfo { | |||
| } | |||
| } | |||
|
|
|||
| /// Information on a room key that has been withheld | |||
| #[derive(Clone, Debug, Deserialize, Serialize)] | |||
| pub struct RoomKeyWithheldInfo { | |||
There was a problem hiding this comment.
Might make sense to use this in the store as well, maybe? But probably not worth to do a migration for that.
There was a problem hiding this comment.
Yeahhh. Maybe some other time.
richvdh
added a commit
to matrix-org/matrix-rust-sdk-crypto-wasm
that referenced
this pull request
Jul 11, 2024
Expose the new stream added in matrix-org/matrix-rust-sdk#3660 and matrix-org/matrix-rust-sdk#3674 via a new callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #3660: I realised I didn't want to have to parse the room_id and session_id out of the messages again.