-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto(feat): Key distribution errors for pin violations #3662
Closed
BillCarsonFr
wants to merge
20
commits into
main
from
valere/invisible_crypto/identity_sharing_with_pin
Closed
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
67af31a
feature(crypto): Add support for master key local pinning
BillCarsonFr 8253618
Review: Do not use msk abbreviation
BillCarsonFr b7241c3
Review: Use TryFrom instead of From for serializer helper struct
BillCarsonFr 4d66828
Review: Fix typo
BillCarsonFr c045d26
Review: Improve doc
BillCarsonFr bfb8818
Review: Fix data set comments
BillCarsonFr fb39a9e
Review: Improve comments
BillCarsonFr 1d4cefb
Clippy | unneeded clone
BillCarsonFr de60e6e
refactor: Rename serializer helper to match new OtherUserIdentityData
BillCarsonFr 7803617
crypto: refactor extract detection of removed device from outbound
BillCarsonFr 9b00de3
refactor: Move user loop inside strategy specific branch
BillCarsonFr e309219
feat(crypto): Key distribution errors for Pin violations
BillCarsonFr 2a174b0
naming and formatting changes
uhoreg 462b39a
Merge branch 'main' into valere/invisible_crypto/identity_sharing_wit…
uhoreg c2332ce
don't share with our own device
uhoreg ff46fc1
Merge branch 'main' into valere/invisible_crypto/identity_sharing_wit…
uhoreg 6b03ef3
remove commented-out debugging line
uhoreg afda06a
only error with a pin violation if they were previously verified
uhoreg fd15720
apply changes from review
uhoreg f75934f
document tests
uhoreg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3810 added a "SessionRecipientCollectionError" which I think we should be using here, rather than adding a new error type.