feat(ui): Trigger room list update only when necessary #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch revisits the need to trigger a room list update for all changes of `RoomInfo`. For the moment, it reduces the scope to `recency_timestamp` update. This patch comes with a test to ensure things work as expected.
Hywan
force-pushed
the
feat-ui-room-list-roominfo-update
branch
3 times, most recently
from
85015e2 to
7772c22
Compare
Hywan
force-pushed
the
feat-ui-room-list-roominfo-update
branch
from
7772c22 to
77feed2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3646 +/- ##
=======================================
Coverage 84.26% 84.27%
=======================================
Files 259 259
Lines 26505 26559 +54
=======================================
+ Hits 22334 22382 +48
- Misses 4171 4177 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch revisits the need to trigger a room list update for all changes of
RoomInfo. For the moment, it reduces the scope torecency_timestampupdate.This patch comes with a test to ensure things work as expected.