Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Trigger room list update only when necessary #3646

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Jul 3, 2024

This patch revisits the need to trigger a room list update for all changes of RoomInfo. For the moment, it reduces the scope to recency_timestamp update.

This patch comes with a test to ensure things work as expected.

@Hywan Hywan requested a review from a team as a code owner July 3, 2024 13:41
@Hywan Hywan requested review from bnjbvr and removed request for a team July 3, 2024 13:41
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

This patch revisits the need to trigger a room list update for
all changes of `RoomInfo`. For the moment, it reduces the scope to
`recency_timestamp` update.

This patch comes with a test to ensure things work as expected.
@Hywan Hywan force-pushed the feat-ui-room-list-roominfo-update branch 3 times, most recently from 85015e2 to 7772c22 Compare July 3, 2024 18:19
@Hywan Hywan force-pushed the feat-ui-room-list-roominfo-update branch from 7772c22 to 77feed2 Compare July 3, 2024 18:56
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.27%. Comparing base (3588b88) to head (77feed2).
Report is 51 commits behind head on main.

Files Patch % Lines
crates/matrix-sdk-ui/src/room_list_service/room.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3646   +/-   ##
=======================================
  Coverage   84.26%   84.27%           
=======================================
  Files         259      259           
  Lines       26505    26559   +54     
=======================================
+ Hits        22334    22382   +48     
- Misses       4171     4177    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan Hywan merged commit a957e70 into matrix-org:main Jul 3, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants