Indexeddb: more efficient serialization format #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
approved these changes
Jul 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3645 +/- ##
=======================================
Coverage 84.19% 84.20%
=======================================
Files 256 256
Lines 26600 26600
=======================================
+ Hits 22397 22399 +2
+ Misses 4203 4201 -2 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Jul 3, 2024
I'm going to change the behaviour of `serialize_value`, and we want to preserve the behaviour of this test.
... and make `deserialize_value` handle both the old and new formats. `maybe_encrypt_value` uses a much more efficient representation, so let's migrate to that.
Now that `deserialize_value` returns an `IndexeddbCryptoStoreError`, we don't need these any more.
richvdh
force-pushed
the
rav/indexeddb_storage_efficiency
branch
from
0440722 to
4d12a78
Compare
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current serialization format that we use for most objects in the indexeddb crypto store is extremely space-inefficient, leading to poor performance and errors (cf element-hq/element-web#27658).
The idea here is to switch to the more efficient format used by
maybe_encrypt_value. To avoid a huge migration step, we make the deserialization routine handle either format.