integration tests: make randomize_username() the default #3641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3641 +/- ##
==========================================
- Coverage 84.19% 84.17% -0.02%
==========================================
Files 256 256
Lines 26594 26594
==========================================
- Hits 22390 22385 -5
- Misses 4204 4209 +5 ☔ View full report in Codecov by Sentry. |
bnjbvr
force-pushed
the
bnjbvr/it-make-randomize-username-the-default
branch
from
d28348e to
7c60ef9
Compare
Most tests would randomize the username when creating a `TestClientBuilder`; make it the default, since it's a sensible choice, and avoids interference between different tests / test runs. A single test required an actual non-randomized username, so a specific way to opt out from this new default behavior has been introduced.
…on in `TestClientBuilder` DRY.
bnjbvr
force-pushed
the
bnjbvr/it-make-randomize-username-the-default
branch
from
7c60ef9 to
f9fca67
Compare
poljar
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most tests would randomize the username when creating a
TestClientBuilder; make it the default, since it's a sensible choice, and avoids interference between different tests / test runs.A single test required an actual non-randomized username, so a specific way to opt out from this new default behavior has been introduced.