chore: Remove the get_ of some Store's methods
#3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch renames `Store::get_rooms`, `::get_rooms_filtered` and `::get_room` to respectively `::rooms`, `::rooms_filtered` and `::room`. This `get_` prefix isn't really Rust idiomatic.
Hywan
force-pushed
the
chore-sdk-remove-get-prefix
branch
from
29f6e1d to
0ecb8a3
Compare
Just like in matrix-org#3552, this patch updates `Store::rooms_filtered` to not call `Store::room` so that it doesn't lock `rooms` for each item, thus making it way faster.
Hywan
force-pushed
the
chore-sdk-remove-get-prefix
branch
from
0ecb8a3 to
408c12f
Compare
This patch renames `Client::get_rooms`, `::get_rooms_filtered` and `::get_room` to respectively `::rooms`, `::rooms_filtered` and `::room`. This `get_` prefix isn't really Rust idiomatic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3554 +/- ##
==========================================
- Coverage 83.82% 83.82% -0.01%
==========================================
Files 253 253
Lines 25890 25887 -3
==========================================
- Hits 21703 21700 -3
Misses 4187 4187 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames
Store::get_rooms,::get_rooms_filteredand::get_roomto respectively::rooms,::rooms_filteredand::room. Thisget_prefix isn't really Rust idiomatic.This patch also fix
Store::rooms_filteredto not callStore::room, thus not locking the entireroomsfor every item, making it everything faster.Client::rooms_stream#3068,Store::get_roomswayyy faster #3552 with the update ofrooms_filtered,