chore(ffi): Remove RoomInfo::latest_event
#3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3541 +/- ##
=======================================
Coverage 83.82% 83.83%
=======================================
Files 253 253
Lines 25843 25843
=======================================
+ Hits 21664 21666 +2
+ Misses 4179 4177 -2 ☔ View full report in Codecov by Sentry. |
bnjbvr
approved these changes
Jun 13, 2024
Hywan
force-pushed
the
chore-ffi-roominfo-latest-event
branch
from
36b3b8e to
63bcf51
Compare
This patch removes `RoomInfo::latest_event`. To get the latest event, one has to use `RoomListItem::latest_event` because it supports local events and remote events. It was supposed to be the case of `Room::room_info` too, but only when the method was called: Once the `RoomInfo` was created, the latest event inside `RoomInfo` was static, not dynamic. Also, this code wasn't tested contrary to `RoomListItem::latest_event` which uses `matrix_sdk_ui::room_list_service::Room::latest_event` which is itself tested.
Hywan
force-pushed
the
chore-ffi-roominfo-latest-event
branch
from
63bcf51 to
01a36c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes
RoomInfo::latest_event. To get the latest event,one has to use
RoomListItem::latest_eventbecause it supportslocal events and remote events. It was supposed to be the case of
Room::room_infotoo, but only when the method was called: Once theRoomInfowas created, the latest event insideRoomInfowas static, not dynamic. Also, this code wasn't tested
contrary to
RoomListItem::latest_eventwhich usesmatrix_sdk_ui::room_list_service::Room::latest_eventwhich is itselftested.
room_list_service::Room::latest_eventno longer usesSlidingSyncRoom(+ dropSlidingSyncRoomExt) #3540.