room names: better make use of the hero names for locally computing a room display name #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch does 3 things: 1. It updates Ruma to the latest revision at the time of writing, 2. It updates `matrix-sdk-ffi` to provide the `RoomSubscription::include_heroes` field, 3. It updates `matrix-sdk-base` so that SlidingSync consumes `heroes` from the response and update the `RoomSummary` accordingly. A test has been added to ensure the `RoomSummary` is updated as expected.
Since rendering is sync, and I want the computed display name (which retrieval is async), I have to fetch the display name early, just after getting the room. Oh well :)
This is the right goal, and Ruma will be updated to reflect that the `heroes` field should contain `OwnedUserId` too in [1]. This simplifies the code a bit, and avoids a round-trip encoding user-ids into a string then decoding them from a string later, in the case of sliding sync and room name computation. [1] ruma/ruma#1822
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3461 +/- ##
=======================================
Coverage 83.28% 83.29%
=======================================
Files 248 248
Lines 25198 25220 +22
=======================================
+ Hits 20987 21007 +20
- Misses 4211 4213 +2 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
May 27, 2024
|
|
||
| let members: StoreResult<Vec<_>> = members.into_iter().collect(); | ||
| let (heroes, guessed_num_members): (Vec<String>, _) = if !summary.heroes_names.is_empty() { | ||
| // Straight-forward path: pass through the heroes names, don't give a guess of |
There was a problem hiding this comment.
- Straight-forward
+ Straightforward
bnjbvr
commented
May 27, 2024
Signed-off-by: Benjamin Bouvier <[email protected]>
|
Address part of #3272. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #3441 but since I've added many commits while taking it over, reopening a new PR for it.
This makes it so that we prefer using the hero names if we receive those from the sliding sync, rather than retrieving the names from the room members that are hero, or retrieving the room members from the first N members.
I've also updated the very unfortunate edge case where we have 0 heroes to display "n people" instead of ", and n others.".