Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base: sort the heroes in the computed display name alphabetically #3377

Merged
merged 1 commit into from
May 13, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented May 2, 2024

This ensures the room name is deterministic, when it's computed client-side. Includes regression tests too, where the members or heroes might not be in the expected order.

@bnjbvr bnjbvr requested a review from a team as a code owner May 2, 2024 13:31
@bnjbvr bnjbvr requested review from andybalaam and removed request for a team May 2, 2024 13:31
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.92%. Comparing base (2987bd1) to head (16aa8c6).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/matrix-sdk-base/src/rooms/normal.rs 94.11% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3377   +/-   ##
=======================================
  Coverage   82.92%   82.92%           
=======================================
  Files         245      245           
  Lines       24894    24897    +3     
=======================================
+ Hits        20643    20646    +3     
  Misses       4251     4251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

crates/matrix-sdk-base/src/rooms/normal.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-base/src/rooms/normal.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-base/src/rooms/normal.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-base/src/rooms/normal.rs Show resolved Hide resolved
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(wrongly sent the review before)

Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ahead of time to avoid back and forth during the review process.

@bnjbvr bnjbvr force-pushed the bnjbvr/sort-room-members branch from 3c2a132 to fded104 Compare May 13, 2024 12:59
@bnjbvr bnjbvr force-pushed the bnjbvr/sort-room-members branch from fded104 to 16aa8c6 Compare May 13, 2024 12:59
@bnjbvr bnjbvr enabled auto-merge (rebase) May 13, 2024 13:10
@bnjbvr bnjbvr merged commit 94d3758 into main May 13, 2024
35 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/sort-room-members branch May 13, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants