-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sort the heroes in the computed display name alphabetically #3377
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3377 +/- ##
=======================================
Coverage 82.92% 82.92%
=======================================
Files 245 245
Lines 24894 24897 +3
=======================================
+ Hits 20643 20646 +3
Misses 4251 4251 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(wrongly sent the review before)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ahead of time to avoid back and forth during the review process.
3c2a132
to
fded104
Compare
fded104
to
16aa8c6
Compare
This ensures the room name is deterministic, when it's computed client-side. Includes regression tests too, where the members or heroes might not be in the expected order.