feat: use a ring buffer for the RoomListService cache
#2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
approved these changes
Jul 10, 2023
| /// This number should be high enough so that navigating to a room | ||
| /// previously visited is almost instant, but also not too high so as to | ||
| /// avoid exhausting memory. | ||
| const ROOM_OBJECT_CACHE_SIZE: usize = 16; |
There was a problem hiding this comment.
That seems to quite low, no? Some bigger tablets or desktop clients might fit that many rooms into the view.
How about ~100? Or 128 if you want it to remain a power of 2.
There was a problem hiding this comment.
Ivan suggested 20. I don't think it's a big issue to have a lot (the linear search may take longer, but it's nothing in the grand scheme of things), so I can use 128 (:nerd_face:) indeedy.
This will limit the memory used by the cache entries (while it was unbounded before). It's now possible to do this, since we have the `latest_room_event` handy for all the rooms; using the unbounded cache before was papering over the lack of that feature. We can bikeshed on the number of entries in this cache. It has to be small enough to not blow up memory (and keep the linear search over room id fast, but it's secondary), and high enough that we don't hit the full timeline re-build path that often.
bnjbvr
force-pushed
the
ring-buffer-room-cache
branch
from
d08cf70 to
8c83d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will limit the memory used by the cache entries (while it was unbounded before). It's now possible to do this, since we have the
latest_room_eventhandy for all the rooms; using the unbounded cache before was papering over the lack of that feature.We can bikeshed on the number of entries in this cache. It has to be small enough to not blow up memory (and keep the linear search over room id fast, but it's secondary), and high enough that we don't hit the full timeline re-build path that often.
Address a bullet point in #1911.