feat(ui+ffi): Add various features to RoomList
#2054
Conversation
…les. No code changes. This patch is just moving things around.
…` in `RoomList`.
Hywan
force-pushed
the
feat-ui-roomlist-more-features-on-item
branch
from
5143fee to
1c87728
Compare
Hywan
changed the title
RoomList
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2054 +/- ##
==========================================
+ Coverage 75.59% 75.70% +0.11%
==========================================
Files 149 151 +2
Lines 16158 16174 +16
==========================================
+ Hits 12214 12244 +30
+ Misses 3944 3930 -14
☔ View full report in Codecov by Sentry. |
| @@ -198,6 +198,10 @@ impl RoomListItem { | |||
| RUNTIME.block_on(async { self.inner.name().await }) | |||
| } | |||
|
|
|||
| fn full_room(&self) -> Arc<Room> { | |||
There was a problem hiding this comment.
It's a legacy term that means: gimme the matrix_sdk_ffi:Room instance. Happy to change to something more meaningful.
There was a problem hiding this comment.
Ah ok, as a newcomer this feels a bit strange, maybe room would be sufficient? (no strong opinion here, so you choose)
| @@ -89,7 +90,8 @@ impl Action for AddVisibleRoomsList { | |||
| .add_list( | |||
| SlidingSyncList::builder(VISIBLE_ROOMS_LIST_NAME) | |||
| .sync_mode(SlidingSyncMode::new_selective()) | |||
| .timeline_limit(20), | |||
| .timeline_limit(20) | |||
| .required_state(vec![(StateEventType::RoomEncryption, "".to_owned())]), | |||
There was a problem hiding this comment.
Should we also enable m.room.member events here, to help address #2004?
There was a problem hiding this comment.
Maybe! @poljar, @stefanceriu, @manuroe, any thoughts?
There was a problem hiding this comment.
Isn't damir talking only about the rooms you're subscribing to and not the full lists? 🤔
There was a problem hiding this comment.
Yes, you're only sending events in a room that you're subscribed to. So only there we'll need the member events.
| ]), | ||
| ]) | ||
| .filters(Some(assign!(SyncRequestListFilters::default(), { | ||
| is_invite: Some(false), |
There was a problem hiding this comment.
Sometime later, maybe when the list has been fully loaded, we need to flip this to true, otherwise we won't ever get invites?
There was a problem hiding this comment.
We will create a special list dedicated to invites. As it's the case in ElementX right now.
| @@ -198,6 +198,10 @@ impl RoomListItem { | |||
| RUNTIME.block_on(async { self.inner.name().await }) | |||
| } | |||
|
|
|||
| fn full_room(&self) -> Arc<Room> { | |||
There was a problem hiding this comment.
Ah ok, as a newcomer this feels a bit strange, maybe room would be sufficient? (no strong opinion here, so you choose)
Address #1911.
This PR must be reviewed commit by commit.