Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove dependency on broken wasm_timer crate #1488

Merged
merged 2 commits into from
Feb 13, 2023
Merged

fix: remove dependency on broken wasm_timer crate #1488

merged 2 commits into from
Feb 13, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Feb 10, 2023 •
edited
Loading

wasm_timer doesn't work outside the browser, which prevents it being used in tests.

We can replace it with gloo-timers wich uses the standard Javascript setTimeout.

Fixes: #896
Fixes: #1443.

@richvdh richvdh force-pushed the rav/fix_wasm_timeout branch 2 times, most recently from 9fc3738 to 42a59ad Compare February 10, 2023 14:33
@richvdh richvdh marked this pull request as draft February 10, 2023 14:33
@richvdh
fix: remove dependency on broken wasm_timer crate
ea62847 
`wasm_timer` doesn't work outside the browser, which prevents it being used in
tests.

We can replace it with `gloo-timers` wich uses the standard Javascript
`setTimeout`.

Fixes: #896, #1443.
@richvdh richvdh force-pushed the rav/fix_wasm_timeout branch from 42a59ad to ea62847 Compare February 10, 2023 14:39
@richvdh richvdh marked this pull request as ready for review February 10, 2023 15:16
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 74.15% // Head: 74.13% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (ef7b9cd) compared to base (441626b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1488      +/-   ##
==========================================
- Coverage   74.15%   74.13%   -0.02%     
==========================================
  Files         124      124              
  Lines       13696    13699       +3     
==========================================
  Hits        10156    10156              
- Misses       3540     3543       +3
Impacted Files Coverage Δ
crates/matrix-sdk-common/src/timeout.rs 58.82% <0.00%> (-12.61%) ⬇️
crates/matrix-sdk/src/sync.rs 85.36% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

poljar
poljar approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Sorry I couldn't take care of this, things are a bit hectic currently.

@poljar poljar merged commit 8d64278 into main Feb 13, 2023
@poljar poljar deleted the rav/fix_wasm_timeout branch February 13, 2023 11:41
@richvdh
Copy link
Member Author

richvdh commented Feb 13, 2023

Sorry I couldn't take care of this, things are a bit hectic currently.

no worries at all, I enjoyed the excuse for a diversion into rust-land!

@Hywan
Copy link
Member

Hywan commented Feb 14, 2023

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poljar poljar poljar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@richvdh @Hywan @poljar