Sliding Sync timeline events and extensions

[gnunicorn]

• general extensions framework
  • still needs a ruma patch to complete first, refs Update sliding sync to latest ruma/ruma#1273
• E2EE Extension support
• ToDevice Extension support
• AccountData Extension support
• Timeline events support

refs #1014

[jplatte]

I have just released ruma 0.7.4 with the sliding sync changes.

[Hywan]

Minor comments, good work!

[codecov]

Codecov Report

Base: 73.17% // Head: 73.17% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (773b587) compared to base (9de98df).
Patch coverage: 80.55% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1054   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files         110      110           
  Lines       12256    12265    +9     
=======================================
+ Hits         8968     8975    +7     
- Misses       3288     3290    +2     

Impacted Files	Coverage Δ
...es/matrix-sdk-common/src/deserialized_responses.rs	62.16% <ø> (ø)
crates/matrix-sdk/src/sliding_sync.rs	0.00% <0.00%> (ø)
crates/matrix-sdk-base/src/client.rs	77.33% <88.46%> (+0.30%)	⬆️
crates/matrix-sdk-crypto/src/machine.rs	66.83% <100.00%> (-0.18%)	⬇️
crates/matrix-sdk/src/sync.rs	71.42% <100.00%> (+2.46%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[poljar]

Looks mostly good. One thing beside the nits, now that E2EE is supposed to work with sliding sync and jack-in we need to change the text for the Get access token section.

The way it is, it's going to produce broken E2EE setups. The access token that you can get from Element is already bound to a set of E2EE keys. A new access token needs to be created, either using curl-like tools or jack-in needs to support logging in. Using httpie you can log in using this snippet:

$ https POST https://matrix.org/_matrix/client/v3/login type="m.login.password" password=foo identifier:='{"type": "m.id.user", "user": "@bar:matrix.org"}'

Another jack-in problem, it hardcodes a device id, that won't ever work with E2EE, the following diff lets you configure it:

diff --git a/labs/jack-in/src/main.rs b/labs/jack-in/src/main.rs
index d3b47a41c7..b786f21099 100644
--- a/labs/jack-in/src/main.rs
+++ b/labs/jack-in/src/main.rs
@@ -83,6 +83,10 @@ struct Opt {
     #[structopt(short, long, env = "JACKIN_USER")]
     user: String,
 
+    /// The device ID associated with this access token
+    #[structopt(short, long, env = "JACKIN_DEVICE_ID")]
+    device_id: String,
+
     #[structopt(long)]
     /// Activate tracing and write the flamegraph to the specified file
     flames: Option<PathBuf>,
@@ -112,7 +116,7 @@ async fn main() -> Result<()> {
     let opt = Opt::from_args();
 
     let user_id: OwnedUserId = opt.user.clone().parse()?;
-    let device_id: OwnedDeviceId = "XdftAsd".into();
+    let device_id: OwnedDeviceId = opt.device_id.into();
 
     if let Some(ref p) = opt.flames {
         setup_flames(p.as_path());

Lastly jack-in doesn't seem to work currently with the hosted sliding sync proxy:

I'll tag this as requesting changes, since I'll want to retest it once the proxy works.

[poljar]

Seems like the proxy has an issue with one-time key counts, opened matrix-org/sliding-sync#52 for that.

[poljar]

And another, rather critical issue: matrix-org/sliding-sync#53

[poljar]

While we're waiting for the sliding sync proxy to start working, the file-logging feature of jack-in doesn't compile anymore.

[poljar]

Alright, seems like everything works now.