Use export_room_keys_stream to reduce export memory usage #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
force-pushed
the
andybalaam/export-as-stream
branch
from
331474c to
bcc13c2
Compare
andybalaam
changed the base branch from
main
to
andybalaam/update-rust-sdk-for-export_room_keys_stream
bnjbvr
approved these changes
Feb 20, 2024
| T: Serialize, | ||
| S: Stream<Item = T>, | ||
| { | ||
| let mut stream_json = vec![]; |
There was a problem hiding this comment.
Would initializing with an initial capacity make sense? Assuming the stream's not empty, we can likely avoid many reallocations by having a large initial size here?
There was a problem hiding this comment.
I think so, but I don't know how to estimate a good size here. Do we do anything similar anywhere else in the code? Do we have any rules of thumb?
Base automatically changed from
andybalaam/update-rust-sdk-for-export_room_keys_stream
to
main
February 21, 2024 12:30
It's already tested in machine.test.ts. |
andybalaam
force-pushed
the
andybalaam/export-as-stream
branch
from
bcc13c2 to
0861298
Compare
Signed-off-by: Andy Balaam <[email protected]>
andybalaam
force-pushed
the
andybalaam/export-as-stream
branch
from
0861298 to
66c6ddf
Compare
andybalaam
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Feb 22, 2024
To reduce memory usage during export - see matrix-org/matrix-rust-sdk-crypto-wasm#105
github-merge-queue bot
pushed a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Feb 22, 2024
To reduce memory usage during export - see matrix-org/matrix-rust-sdk-crypto-wasm#105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies on top of #106
Make use of the new
export_room_keys_streammethod from matrix-org/matrix-rust-sdk#3144 to avoid one copy of the keys in the export process, by directly serialising to a JSON string, without taking the intermediate step into aVec<ExportedRoomKey>.Part of element-hq/element-web#26681