Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Fix: Ending dictation crashes RTE #924

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 17, 2024

This is caused by a call to super in an override that is actually an optional objc protocol func in disguise, making the super call actually call an unused selector

@Velin92 Velin92 requested a review from stefanceriu January 17, 2024 08:58
@Velin92 Velin92 enabled auto-merge (squash) January 17, 2024 08:59
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c3aaa3) 87.40% compared to head (bb738b0) 89.50%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #924      +/-   ##
============================================
+ Coverage     87.40%   89.50%   +2.10%     
============================================
  Files           167       86      -81     
  Lines         19055    15371    -3684     
  Branches       1040        0    -1040     
============================================
- Hits          16655    13758    -2897     
+ Misses         2093     1613     -480     
+ Partials        307        0     -307     
Flag Coverage Δ
uitests ?
uitests-android ?
uitests-ios ?
unittests 89.50% <ø> (+3.90%) ⬆️
unittests-android ?
unittests-ios ?
unittests-rust 89.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 merged commit 1a566e6 into main Jan 17, 2024
7 checks passed
@Velin92 Velin92 deleted the mauroromito/fix_Crash_for_dictation branch January 17, 2024 09:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants