Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

[Android] Add customisation options for links and code #813

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

jonnyandrew
Copy link
Contributor

Changes

There are a few semi-related changes in this PR which can be reviewed commit by commit (or split into separate PRs if needed).

  • Allow customisation of link color
  • Allow customisation of code and inline code backgrounds
  • Refactor code and inline code background styles (so that apps do not need to handle drawables directly)
  • Add useful compose debugging config
  • Fix a few mutability/instability issues in the example app and core view library

Context

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +1.59% 🎉

Comparison is base (ac03500) 88.28% compared to head (b940949) 89.88%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #813      +/-   ##
============================================
+ Coverage     88.28%   89.88%   +1.59%     
============================================
  Files           155       82      -73     
  Lines         17882    14716    -3166     
  Branches        862        0     -862     
============================================
- Hits          15788    13227    -2561     
+ Misses         1860     1489     -371     
+ Partials        234        0     -234     
Flag Coverage Δ
uitests ?
uitests-android ?
uitests-ios ?
unittests 89.88% <ø> (+2.96%) ⬆️
unittests-android ?
unittests-ios ?
unittests-rust 89.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 73 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonnyandrew jonnyandrew requested a review from a team September 15, 2023 16:49
@jonnyandrew jonnyandrew marked this pull request as ready for review September 15, 2023 16:49
Copy link

@julioromano julioromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor nit!

}

composeOptions {
kotlinCompilerExtensionVersion '1.5.1'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: we are at 1.5.3 now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I used this version to align with the other modules in the project but will update separately 👍

@jonnyandrew jonnyandrew merged commit 3e43465 into main Sep 18, 2023
6 of 7 checks passed
@jonnyandrew jonnyandrew deleted the jonny/compose-styles branch September 18, 2023 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants