Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

[iOS] Add support to custom placeholder color #810

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

alfogrillo
Copy link
Contributor

No description provided.

@alfogrillo alfogrillo requested a review from a team September 14, 2023 15:44
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alfogrillo alfogrillo changed the title Add support to custom placeholder color [iOS] Add support to custom placeholder color Sep 14, 2023
@alfogrillo alfogrillo added the iOS label Sep 14, 2023
Copy link
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this take dark mode into account?

@alfogrillo
Copy link
Contributor Author

Does this take dark mode into account?

Yes, it does. A Color has both states (dark, light) into it.

Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@alfogrillo alfogrillo merged commit 5aca3bb into main Sep 15, 2023
9 checks passed
@alfogrillo alfogrillo deleted the alfogrillo/placeholder-color branch September 15, 2023 08:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants