This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix broadcast last sequence number #9858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeman1337
added
the
T-Task
weeman1337
force-pushed
the
weeman1337/fix-broadcast-last-sequence
branch
from
3dcf645 to
eda9a19
Compare
germain-gg
suggested changes
Jan 9, 2023
germain-gg
approved these changes
Jan 9, 2023
andybalaam
pushed a commit
to andybalaam/matrix-react-sdk
that referenced
this pull request
Jan 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the sequence number is initialised with 1 and incremented after sending an event. This leads to wrong info events, sending the current sequence number always 1 ahead.
Fix should be initialisation with 0 and increment just before sending the next event.
closes element-hq/element-web#24155
PSF-1835
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.