-
-
Notifications
You must be signed in to change notification settings - Fork 828
Add voice broadcast seek 30s forward/backward buttons #9592
Conversation
44a8afa
to
b939587
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit surprised to see voice broadcast in its own tree as well - we likely aren't applying the correct CI checks to the tree. It should be merged into the existing src/components
structure (in another PR).
@@ -326,7 +485,7 @@ exports[`VoiceBroadcastPlaybackBody when rendering a stopped broadcast and the l | |||
<span | |||
class="mx_Clock" | |||
> | |||
00:42 | |||
23:42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implies an unexpected change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is expected. I've added another test to explicitly look for the time update.
comes from here
As far as I remember we wanted to keep voice broadcast separated from the rest for now.
Are there any checks not running or running differently for that part? |
I believe there's some checks which only run in |
Part of element-hq/element-web#23282
PSF-1587
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.