Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add voice broadcast seek 30s forward/backward buttons #9592

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Nov 17, 2022

Part of element-hq/element-web#23282

PSF-1587

image

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Nov 17, 2022
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-seek30s branch from 44a8afa to b939587 Compare November 17, 2022 14:49
@weeman1337 weeman1337 marked this pull request as ready for review November 17, 2022 15:10
@weeman1337 weeman1337 requested a review from a team as a code owner November 17, 2022 15:10
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised to see voice broadcast in its own tree as well - we likely aren't applying the correct CI checks to the tree. It should be merged into the existing src/components structure (in another PR).

@@ -326,7 +485,7 @@ exports[`VoiceBroadcastPlaybackBody when rendering a stopped broadcast and the l
<span
class="mx_Clock"
>
00:42
23:42
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implies an unexpected change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weeman1337
Copy link
Contributor Author

I'm a bit surprised to see voice broadcast in its own tree as well

As far as I remember we wanted to keep voice broadcast separated from the rest for now.

we likely aren't applying the correct CI checks to the tree

Are there any checks not running or running differently for that part?

@weeman1337 weeman1337 requested a review from turt2live November 18, 2022 07:41
@turt2live
Copy link
Member

Are there any checks not running or running differently for that part?

I believe there's some checks which only run in src/components, but I may be mistaken (or they were removed). Either way, would be good to put the code into the rest of the tree, even if it is "temporary".

@weeman1337 weeman1337 merged commit d699f56 into develop Nov 21, 2022
@weeman1337 weeman1337 deleted the weeman1337/voice-broadcast-seek30s branch November 21, 2022 07:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants