This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 830
Fix ThreadView
tests not using thread flag
#9547
Merged
MadLittleMods
merged 4 commits into
develop
from
madlittlemods/no-addEventToTimeline-mixing
Nov 7, 2022
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c516642
Fix ThreadView tests not using thread flag
MadLittleMods 29e1681
Define supportsExperimentalThreads for tests
MadLittleMods 15052d0
Merge branch 'develop' into madlittlemods/no-addEventToTimeline-mixing
MadLittleMods 7a0abe0
Merge branch 'develop' into madlittlemods/no-addEventToTimeline-mixing
t3chguy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -108,6 +108,7 @@ describe("ThreadView", () => { | |
stubClient(); | ||
mockPlatformPeg(); | ||
mockClient = mocked(MatrixClientPeg.get()); | ||
jest.spyOn(mockClient, "supportsExperimentalThreads").mockReturnValue(true); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With the changes in matrix-org/matrix-js-sdk#2856, the reason the tests failed before without this was because |
||
|
||
room = new Room(ROOM_ID, mockClient, mockClient.getUserId() ?? "", { | ||
pendingEventOrdering: PendingEventOrdering.Detached, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Threads don't need to be on for these tests but
supportsExperimentalThreads()
needs to be defined