This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
Oct 27, 2022
t3chguy
reviewed
Oct 31, 2022
.github/workflows/tests.yml
Outdated
@@ -26,7 +26,7 @@ jobs: | |||
run: "./scripts/ci/install-deps.sh --ignore-scripts" | |||
|
|||
- name: Run tests with coverage | |||
run: "yarn coverage --ci --silent > /dev/null 2>&1" | |||
run: "yarn test --coverage --ci --reporters=jest-silent-reporter '--reporters=<rootDir>/test/reporter.js'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please use the github-actions reporter like we do for js-sdk? This shows the failures in the diff tab. It also silences the output in the logs. https://github.com/matrix-org/matrix-js-sdk/blob/develop/.github/workflows/tests.yml#L29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll use it for the "final" run
Fyi, this PR is in a very WIP stage, more a playground for analysis and improvement :)
…tion-time-jest-test
…tion-time-jest-test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Following the issue element-hq/element-web#21971, the purpose here is to improve the execution time of jest tests.
Analysis
When removing the output: 14mins to 11minsI executed multiple times the test, sometimes the executing is lesser, sometimes the same....
(node:78368) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 OwnBeaconStore.LivenessChange listeners added to [OwnBeaconStore]. Use emitter.setMaxListeners() to increase limit
This point is interessant, in my laptop which has more ressources, the warning is present but the tests are not slowed by this issue.
I expected to have a different execution time between the environnement but to have the same tests and test suites in the TOP 10 below.
This change is marked as an internal change (Task), so will not be included in the changelog.