Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Hide sticker picker for local rooms (backport) #9180

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Aug 12, 2022

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Notes: The first message in a DM can no longer be a sticker. This has been changed to avoid issues with the integration manager.


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • The first message in a DM can no longer be a sticker. This has been changed to avoid issues with the integration manager. (#9180).

* Disable stickers for local rooms

* Use prop
@weeman1337 weeman1337 added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Aug 12, 2022
@weeman1337 weeman1337 marked this pull request as ready for review August 12, 2022 10:10
@weeman1337 weeman1337 requested a review from a team as a code owner August 12, 2022 10:10
@weeman1337 weeman1337 requested review from turt2live, t3chguy and duxovni and removed request for a team August 12, 2022 10:10
@SimonBrandner
Copy link
Contributor

/me wonders if this was supposed to be done by automation - cc @t3chguy

@t3chguy
Copy link
Member

t3chguy commented Aug 12, 2022

@SimonBrandner the automation is still being trialed on the js-sdk repo

@t3chguy t3chguy merged commit cc3ace2 into release-v3.52.0 Aug 12, 2022
@t3chguy t3chguy deleted the weeman1337/backport-no-local-stickers branch August 12, 2022 10:33
@SimonBrandner
Copy link
Contributor

@SimonBrandner the automation is still being trialed on the js-sdk repo

Ah, I see!

su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this pull request Aug 22, 2022
* Device manager - New device tile info design ([\matrix-org#9122](matrix-org#9122)). Contributed by @kerryarchibald.
* Device manager generic settings subsection component ([\matrix-org#9147](matrix-org#9147)). Contributed by @kerryarchibald.
* Migrate the hidden read receipts flag to new "send read receipts" option ([\matrix-org#9141](matrix-org#9141)).
* Live location sharing - share location at most every 5 seconds ([\matrix-org#9148](matrix-org#9148)). Contributed by @kerryarchibald.
* Increase max length of voice messages to 15m ([\matrix-org#9133](matrix-org#9133)). Fixes element-hq/element-web#18620.
* Move pin drop out of labs ([\matrix-org#9135](matrix-org#9135)).
* Start DM on first message ([\matrix-org#8612](matrix-org#8612)). Fixes element-hq/element-web#14736.
* Remove "Add Space" button from RoomListHeader when user cannot create spaces ([\matrix-org#9129](matrix-org#9129)).
* The Welcome Home Screen: Dedicated Download Apps Dialog ([\matrix-org#9120](matrix-org#9120)). Fixes element-hq/element-web#22921. Contributed by @justjanne.
* The Welcome Home Screen: "Submit Feedback" pane ([\matrix-org#9090](matrix-org#9090)). Fixes element-hq/element-web#22918. Contributed by @justjanne.
* New User Onboarding Task List ([\matrix-org#9083](matrix-org#9083)). Fixes element-hq/element-web#22919. Contributed by @justjanne.
* Add support for disabling spell checking ([\matrix-org#8604](matrix-org#8604)). Fixes element-hq/element-web#21901.
* Live location share - leave maximised map open when beacons expire ([\matrix-org#9098](matrix-org#9098)). Contributed by @kerryarchibald.
* Some slash-commands (`/myroomnick`) have temporarily been disabled before the first message in a DM is sent. ([\matrix-org#9193](matrix-org#9193)).
* Use stable reference for active tab in tabbedView ([\matrix-org#9145](matrix-org#9145)). Contributed by @kerryarchibald.
* Fix pillification sometimes doubling up ([\matrix-org#9152](matrix-org#9152)). Fixes element-hq/element-web#23036.
* Fix composer padding ([\matrix-org#9137](matrix-org#9137)). Fixes element-hq/element-web#22992.
* Fix highlights not being applied to plaintext messages ([\matrix-org#9126](matrix-org#9126)). Fixes element-hq/element-web#22787.
* Fix dismissing edit composer when change was undone ([\matrix-org#9109](matrix-org#9109)). Fixes element-hq/element-web#22932.
* 1-to-1 DM rooms with bots now act like DM rooms instead of multi-user-rooms before ([\matrix-org#9124](matrix-org#9124)). Fixes element-hq/element-web#22894.
* Apply inline start padding to selected lines on modern layout only ([\matrix-org#9006](matrix-org#9006)). Fixes element-hq/element-web#22768. Contributed by @luixxiul.
* Peek into world-readable rooms from spotlight ([\matrix-org#9115](matrix-org#9115)). Fixes element-hq/element-web#22862.
* Use default styling on nested numbered lists due to MD being sensitive ([\matrix-org#9110](matrix-org#9110)). Fixes element-hq/element-web#22935.
* Fix replying using chat effect commands ([\matrix-org#9101](matrix-org#9101)). Fixes element-hq/element-web#22824.
* The first message in a DM can no longer be a sticker. This has been changed to avoid issues with the integration manager. ([\matrix-org#9180](matrix-org#9180)).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants