add spaces to TileErrorBoundary

[HarHarLinks]

before	after

Signed-off-by: Kim Brose [email protected]

---

Here's what your changelog entry will look like:

✨ Features

• add spaces to TileErrorBoundary (#9012). Contributed by @HarHarLinks.

[SimonBrandner]

Thank you

[HarHarLinks]

Alright, I thought this was an easy fix, turned out you need some understanding of TS/JSX syntax here. Linter and Tests are happy in my dev environment, apart from a seemingly unrelated error (src/stores/spaces/SpaceStore.ts:21:23 - error TS2305: Module '"matrix-js-sdk/src/client"' has no exported member 'IRoomCapability'.). I can merge develop or rebase if you'd like.

The bigger issue is, I don't know how I would get the error to show in my local dev Element.

[SimonBrandner]

Suggested change

	{ _t("Can't load this message") }
	{ mxEvent && ` (${mxEvent.getType()})` }
	{ mxEvent && ` (${mxEvent.getType()}) ` }
	{ submitLogsButton }
	{ spaceViewSourceButton }
	{ viewSourceButton }
	{ _t("Can't load this message") }  
	{ mxEvent && `(${mxEvent.getType()})` }  
	{ submitLogsButton }  
	{ viewSourceButton }

I think this would probably be the clearest

[HarHarLinks]

{ submitLogsButton }  

wouldn't this insert the space even if there is no viewSourceButton to follow up?

[SimonBrandner]

Argh, true - could we move   into to the if statement?

            if (mxEvent && SettingsStore.getValue("developerMode")) {
                viewSourceButton = <>
					&nbsp;
					<AccessibleButton onClick={this.onViewSource} kind="link">
                    	{ _t("View Source") }
              		</AccessibleButton>
				</>;
            }

[HarHarLinks]

That's what I tried in my last change, without awareness of that empty tags syntax you're proposing. Will update and see what the CI says.

[SimonBrandner]

Sorry about the lengthy review - I have a bit of trouble articulating what I am suggesting 😅

Thank you for your patience with me!

[SimonBrandner]

Suggested change

	{ _t("Can't load this message") }
	{ mxEvent && ` (${mxEvent.getType()})` }
	{ mxEvent && ` (${mxEvent.getType()})` }  
	{ _t("Can't load this message") }  
	{ mxEvent && `(${mxEvent.getType()})` }

could there also be &nbsp in the if statement for submitLogsButton, so that we only add it if necessary?

[SimonBrandner]

Thank you!